]> git.proxmox.com Git - qemu.git/commitdiff
iov: avoid "orig_len may be used unitialized" warning
authorMichael Tokarev <mjt@tls.msk.ru>
Sat, 14 Sep 2013 09:11:36 +0000 (13:11 +0400)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 27 Sep 2013 01:35:32 +0000 (20:35 -0500)
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(cherry picked from commit 2be178a475289286db80de5ddd7830e67e112bdd)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
util/iov.c

index f7055868082dee04b771cc35d73010278ad0579d..bb46c04e4de323eb38fe3e9ff245a5978fe9f30f 100644 (file)
@@ -181,13 +181,11 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
             assert(iov[niov].iov_len > tail);
             orig_len = iov[niov].iov_len;
             iov[niov++].iov_len = tail;
-        }
-
-        ret = do_send_recv(sockfd, iov, niov, do_send);
-
-        /* Undo the changes above before checking for errors */
-        if (tail) {
+            ret = do_send_recv(sockfd, iov, niov, do_send);
+            /* Undo the changes above before checking for errors */
             iov[niov-1].iov_len = orig_len;
+        } else {
+            ret = do_send_recv(sockfd, iov, niov, do_send);
         }
         if (offset) {
             iov[0].iov_base -= offset;