]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
spi: stm32: fix pm_runtime_get_sync() error checking
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Sep 2020 09:43:04 +0000 (12:43 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:46:39 +0000 (14:46 +0100)
BugLink: https://bugs.launchpad.net/bugs/1896824
[ Upstream commit c170a5a3b6944ad8e76547c4a1d9fe81c8f23ac8 ]

The pm_runtime_get_sync() can return either 0 or 1 on success but this
code treats 1 as a failure.

Fixes: db96bf976a4f ("spi: stm32: fixes suspend/resume management")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Alain Volmat <alain.volmat@st.com>
Link: https://lore.kernel.org/r/20200909094304.GA420136@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/spi/spi-stm32.c

index 09b418ff99b16f2bb29528496a4c17e004903f52..9d8ceb63f7db1e7c43ad64b7b2c9a244cf5a5fd3 100644 (file)
@@ -2054,7 +2054,7 @@ static int stm32_spi_resume(struct device *dev)
        }
 
        ret = pm_runtime_get_sync(dev);
-       if (ret) {
+       if (ret < 0) {
                dev_err(dev, "Unable to power device:%d\n", ret);
                return ret;
        }