]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
staging: rtl8712: r8712_enqueue_cmd_ex(): Change return type
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Fri, 21 Jun 2019 06:08:11 +0000 (11:38 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jun 2019 14:46:18 +0000 (16:46 +0200)
Change return type of function r8712_enqueue_cmd_ex from u8 to void as
its return value is never stored, checked or otherwise used. Modify
return statements accordingly.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_cmd.c
drivers/staging/rtl8712/rtl871x_cmd.h

index 163eadba789c33f930ea1975d83037190d2e0d87..66c2f475049783f5f21578ad24d841403ce4e10f 100644 (file)
@@ -163,21 +163,20 @@ void r8712_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *obj)
        complete(&pcmdpriv->cmd_queue_comp);
 }
 
-u32 r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj)
+void r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj)
 {
        unsigned long irqL;
        struct  __queue *queue;
 
        if (!obj)
-               return _SUCCESS;
+               return;
        if (pcmdpriv->padapter->eeprompriv.bautoload_fail_flag)
-               return _FAIL;
+               return;
        queue = &pcmdpriv->cmd_queue;
        spin_lock_irqsave(&queue->lock, irqL);
        list_add_tail(&obj->list, &queue->queue);
        spin_unlock_irqrestore(&queue->lock, irqL);
        complete(&pcmdpriv->cmd_queue_comp);
-       return _SUCCESS;
 }
 
 struct cmd_obj *r8712_dequeue_cmd(struct  __queue *queue)
index 5d0a8568003f0f7510835770bd8014ae2601ceeb..0817d126254f0dd447b028c8f87e278bc11b4c87 100644 (file)
@@ -80,7 +80,7 @@ do {\
 } while (0)
 
 void r8712_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *obj);
-u32 r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj);
+void r8712_enqueue_cmd_ex(struct cmd_priv *pcmdpriv, struct cmd_obj *obj);
 struct cmd_obj *r8712_dequeue_cmd(struct  __queue *queue);
 void r8712_free_cmd_obj(struct cmd_obj *pcmd);
 int r8712_cmd_thread(void *context);