]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 7 Mar 2022 11:51:16 +0000 (11:51 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:39:31 +0000 (14:39 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit c09ac191b1f97cfa06f394dbfd7a5db07986cefc ]

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. Calling of_node_put() to avoid
the refcount leak.

Fixes: 32e67eee670e ("pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220307115116.25316-1-linmq006@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c52703355766c347f270df222a744e0c491a02f2)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/pinctrl/nomadik/pinctrl-nomadik.c

index 39828e9c3120ab0c85bd32f0b80b85127fdba6b1..4757bf964d3cd304c3576ce669640a31e661e6da 100644 (file)
@@ -1883,8 +1883,10 @@ static int nmk_pinctrl_probe(struct platform_device *pdev)
        }
 
        prcm_np = of_parse_phandle(np, "prcm", 0);
-       if (prcm_np)
+       if (prcm_np) {
                npct->prcm_base = of_iomap(prcm_np, 0);
+               of_node_put(prcm_np);
+       }
        if (!npct->prcm_base) {
                if (version == PINCTRL_NMK_STN8815) {
                        dev_info(&pdev->dev,