]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
platform/x86/intel: pmc/core: change pmc_lpm_modes to static
authorTom Rix <trix@redhat.com>
Sat, 23 Apr 2022 12:30:48 +0000 (08:30 -0400)
committerHans de Goede <hdegoede@redhat.com>
Wed, 27 Apr 2022 14:50:25 +0000 (16:50 +0200)
Sparse reports this issue
core.c: note: in included file:
core.h:239:12: warning: symbol 'pmc_lpm_modes' was not declared. Should it be static?

Global variables should not be defined in headers.  This only works
because core.h is only included by core.c. Single file use
variables should be static, so change its storage-class specifier
to static.

Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220423123048.591405-1-trix@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/pmc/core.h

index a46d3b53bf61af76325301b69c5233309b78a7d9..7a059e02c26565ec16ab3690958dc68a3cc508b4 100644 (file)
@@ -236,7 +236,7 @@ enum ppfear_regs {
 #define ADL_LPM_STATUS_LATCH_EN_OFFSET         0x1704
 #define ADL_LPM_LIVE_STATUS_OFFSET             0x1764
 
-const char *pmc_lpm_modes[] = {
+static const char *pmc_lpm_modes[] = {
        "S0i2.0",
        "S0i2.1",
        "S0i2.2",