]> git.proxmox.com Git - mirror_frr.git/commitdiff
isisd: circuit is derefed in every code path
authorDonald Sharp <sharpd@cumulusnetworks.com>
Tue, 24 Sep 2019 23:34:39 +0000 (19:34 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 25 Sep 2019 13:22:52 +0000 (09:22 -0400)
No need to check for circuit being null, we have
already de-refed it in every code path and
would have crashed before this point if it was.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
isisd/isis_te.c

index 44fa45d02b0a9b0bdd05f2b331f3bc15d762b068..9871d2bcb92122574d35635d5f35c9cb3c62908c 100644 (file)
@@ -81,8 +81,7 @@ void isis_link_params_update(struct isis_circuit *circuit,
                return;
 
        /* Sanity Check */
-       if ((circuit == NULL) || (ifp == NULL)
-           || (circuit->state != C_STATE_UP))
+       if ((ifp == NULL) || (circuit->state != C_STATE_UP))
                return;
 
        zlog_debug("TE(%s): Update circuit parameters for interface %s",