]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
opp: of: drop incorrect lockdep_assert_held()
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 10 Oct 2019 10:25:33 +0000 (15:55 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 17:47:00 +0000 (18:47 +0100)
BugLink: https://bugs.launchpad.net/bugs/1850456
commit f2edbb6699b0bc6e4f789846b99007200546c6c2 upstream.

_find_opp_of_np() doesn't traverse the list of OPP tables but instead
just the entries within an OPP table and so only requires to lock the
OPP table itself.

The lockdep_assert_held() was added there by mistake and isn't really
required.

Fixes: 5d6d106fa455 ("OPP: Populate required opp tables from "required-opps" property")
Cc: v5.0+ <stable@vger.kernel.org> # v5.0+
Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/opp/of.c

index b313aca9894fbbb934fc777c1637cbb112d6c506..4c7feb3ac4cda2f01cdf890fe2d1926d5f2a42aa 100644 (file)
@@ -77,8 +77,6 @@ static struct dev_pm_opp *_find_opp_of_np(struct opp_table *opp_table,
 {
        struct dev_pm_opp *opp;
 
-       lockdep_assert_held(&opp_table_lock);
-
        mutex_lock(&opp_table->lock);
 
        list_for_each_entry(opp, &opp_table->opp_list, node) {