]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: comedi: adv_pci1723: remove board reset during (*detach)
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 21 Nov 2014 21:22:29 +0000 (14:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2014 23:39:59 +0000 (15:39 -0800)
The pci1723_reset() function simply resets all the analog output channels
to 0V and a +/-10V range. This really isn't necessary when detaching the
driver.

Remove the board reset and just use comedi_pci_detach() directly for the
(*detach).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adv_pci1723.c

index 87f78367fe95469f426a8364d06b013ae1caa9e3..1b59eb2ff4e9b9578ea5105f51343511ad26c096 100644 (file)
@@ -259,18 +259,11 @@ static int pci1723_auto_attach(struct comedi_device *dev,
        return 0;
 }
 
-static void pci1723_detach(struct comedi_device *dev)
-{
-       if (dev->iobase)
-               pci1723_reset(dev);
-       comedi_pci_detach(dev);
-}
-
 static struct comedi_driver adv_pci1723_driver = {
        .driver_name    = "adv_pci1723",
        .module         = THIS_MODULE,
        .auto_attach    = pci1723_auto_attach,
-       .detach         = pci1723_detach,
+       .detach         = comedi_pci_detach,
 };
 
 static int adv_pci1723_pci_probe(struct pci_dev *dev,