]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
samples/landlock: Fix path_list memory leak
authorTom Rix <trix@redhat.com>
Wed, 28 Apr 2021 21:38:52 +0000 (14:38 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:37:41 +0000 (14:37 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
commit 66b513b7c64a7290c1fbb88e657f7cece992e131 upstream.

Clang static analysis reports this error

sandboxer.c:134:8: warning: Potential leak of memory
  pointed to by 'path_list'
        ret = 0;
              ^
path_list is allocated in parse_path() but never freed.

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20210428213852.2874324-1-trix@redhat.com
Cc: stable@vger.kernel.org
Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 20fbf100f84b9aeb9c91421abe1927bc152bc32b)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
samples/landlock/sandboxer.c

index 7a15910d21718d87d0076ab1f41e523a14856b54..8859fc1935428ed902dda098f0cdd9e5d337507a 100644 (file)
@@ -134,6 +134,7 @@ static int populate_ruleset(
        ret = 0;
 
 out_free_name:
+       free(path_list);
        free(env_path_name);
        return ret;
 }