]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
KVM: Properly check if "page" is valid in kvm_vcpu_unmap
authorKarimAllah Ahmed <karahmed@amazon.de>
Wed, 10 Jul 2019 09:13:13 +0000 (11:13 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Jul 2019 14:25:39 +0000 (16:25 +0200)
The field "page" is initialized to KVM_UNMAPPED_PAGE when it is not used
(i.e. when the memory lives outside kernel control). So this check will
always end up using kunmap even for memremap regions.

Fixes: e45adf665a53 ("KVM: Introduce a new guest mapping API")
Cc: stable@vger.kernel.org
Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/kvm_main.c

index 9613987ef4c8492ed6a920df6fc15946d830e623..49dd5cc73d9504ee5c5eaaf28d242e59c9b57a28 100644 (file)
@@ -1793,7 +1793,7 @@ void kvm_vcpu_unmap(struct kvm_vcpu *vcpu, struct kvm_host_map *map,
        if (!map->hva)
                return;
 
-       if (map->page)
+       if (map->page != KVM_UNMAPPED_PAGE)
                kunmap(map->page);
 #ifdef CONFIG_HAS_IOMEM
        else