]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/xe: Remove uninitialized variable from warning
authorLucas De Marchi <lucas.demarchi@intel.com>
Wed, 20 Dec 2023 16:19:23 +0000 (08:19 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 21:27:45 +0000 (16:27 -0500)
"err" is not initialized when failing to create and add the freq0 sysfs
file. Remove it from the message. This fixes the following warning with
clang:

../drivers/gpu/drm/xe/xe_gt_freq.c:202:30: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
 kobject_name(gt->sysfs), err);
  ^~~

Fixes: bef52b5c7a19 ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
Reviewed-by: MichaƂ Winiarski <michal.winiarski@intel.com>
Link: https://lore.kernel.org/r/20231220161923.3740489-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_gt_freq.c

index 08eabcafe7bccfcaf2e933c6380fd88dd64e6a3e..3adfa6686e7cf9eb2763bccc28b7a0a382dd4834 100644 (file)
@@ -198,8 +198,8 @@ void xe_gt_freq_init(struct xe_gt *gt)
 
        gt->freq = kobject_create_and_add("freq0", gt->sysfs);
        if (!gt->freq) {
-               drm_warn(&xe->drm, "failed to add freq0 directory to %s, err: %d\n",
-                        kobject_name(gt->sysfs), err);
+               drm_warn(&xe->drm, "failed to add freq0 directory to %s\n",
+                        kobject_name(gt->sysfs));
                return;
        }