]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ipv4: Return error for RTA_VIA attribute
authorDavid Ahern <dsahern@gmail.com>
Tue, 26 Feb 2019 17:00:02 +0000 (09:00 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Feb 2019 21:23:17 +0000 (13:23 -0800)
IPv4 currently does not support nexthops outside of the AF_INET family.
Specifically, it does not handle RTA_VIA attribute. If it is passed
in a route add request, the actual route added only uses the device
which is clearly not what the user intended:

  $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0
  $ ip ro ls
  ...
  172.16.1.0/24 dev eth0

Catch this and fail the route add:
  $ ip ro add 172.16.1.0/24 via inet6 2001:db8:1::1 dev eth0
  Error: IPv4 does not support RTA_VIA attribute.

Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_frontend.c

index fe4f6a62423834a79705e0c01cd1329d9da4f836..ed14ec2455847f2f104cb33fcd6a64cd37b87b40 100644 (file)
@@ -710,6 +710,10 @@ static int rtm_to_fib_config(struct net *net, struct sk_buff *skb,
                case RTA_GATEWAY:
                        cfg->fc_gw = nla_get_be32(attr);
                        break;
+               case RTA_VIA:
+                       NL_SET_ERR_MSG(extack, "IPv4 does not support RTA_VIA attribute");
+                       err = -EINVAL;
+                       goto errout;
                case RTA_PRIORITY:
                        cfg->fc_priority = nla_get_u32(attr);
                        break;