]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
PCI: keystone: Fix error handling when "num-viewport" DT property is not populated
authorKishon Vijay Abraham I <kishon@ti.com>
Tue, 21 Jan 2020 11:57:34 +0000 (17:27 +0530)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 17 Feb 2020 09:57:44 +0000 (10:57 +0100)
BugLink: https://bugs.launchpad.net/bugs/1863588
commit b0de922af53eede340986a2d05b6cd4b6d6efa43 upstream.

Fix error handling when "num-viewport" DT property is not populated.

Fixes: 23284ad677a9 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms")
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/pci/controller/dwc/pci-keystone.c

index ea8e7ebd8c4f8b4d8b64e2de790891881f981502..c8c702c494a2da14a1f044bd1504cea9a3fede60 100644 (file)
@@ -1354,7 +1354,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
                ret = of_property_read_u32(np, "num-viewport", &num_viewport);
                if (ret < 0) {
                        dev_err(dev, "unable to read *num-viewport* property\n");
-                       return ret;
+                       goto err_get_sync;
                }
 
                /*