]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: rt274: fix boolean tests
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sat, 5 Jan 2019 02:02:38 +0000 (20:02 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Jan 2019 16:51:46 +0000 (16:51 +0000)
Reported by Coccinelle:

sound/soc/codecs/rt274.c:958:6-8: WARNING: Comparison to bool
sound/soc/codecs/rt274.c:961:6-9: WARNING: Comparison to bool
sound/soc/codecs/rt274.c:384:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt274.c:387:5-8: WARNING: Comparison to bool

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt274.c

index e2855ab9a2c6b5f84a4e179d254564d62cb6efff..9e88f7b25d380897ac24d229013ff20812ded972 100644 (file)
@@ -381,10 +381,10 @@ static void rt274_jack_detect_work(struct work_struct *work)
        if (rt274_jack_detect(rt274, &hp, &mic) < 0)
                return;
 
-       if (hp == true)
+       if (hp)
                status |= SND_JACK_HEADPHONE;
 
-       if (mic == true)
+       if (mic)
                status |= SND_JACK_MICROPHONE;
 
        snd_soc_jack_report(rt274->jack, status,
@@ -955,10 +955,10 @@ static irqreturn_t rt274_irq(int irq, void *data)
        ret = rt274_jack_detect(rt274, &hp, &mic);
 
        if (ret == 0) {
-               if (hp == true)
+               if (hp)
                        status |= SND_JACK_HEADPHONE;
 
-               if (mic == true)
+               if (mic)
                        status |= SND_JACK_MICROPHONE;
 
                snd_soc_jack_report(rt274->jack, status,