]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
sh_eth: Do not print an error message for probe deferral
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 18 May 2017 13:01:35 +0000 (15:01 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 May 2017 15:21:07 +0000 (11:21 -0400)
EPROBE_DEFER is not an error, hence printing an error message like

    sh-eth ee700000.ethernet: failed to initialise MDIO

may confuse the user.

To fix this, suppress the error message in case of probe deferral.
While at it, shorten the message, and add the actual error code.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c

index c85222b02754f5a701f6bab92b765136f10b7a44..2d686ccf971b1b6525d7ded8ec5e43b65b67ee6c 100644 (file)
@@ -3220,7 +3220,8 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
        /* MDIO bus init */
        ret = sh_mdio_init(mdp, pd);
        if (ret) {
-               dev_err(&pdev->dev, "failed to initialise MDIO\n");
+               if (ret != -EPROBE_DEFER)
+                       dev_err(&pdev->dev, "MDIO init failed: %d\n", ret);
                goto out_release;
        }