]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
staging: comedi: adl_pci6208: remove redundant initialization of 'val'
authorColin Ian King <colin.king@canonical.com>
Mon, 12 Mar 2018 23:36:05 +0000 (23:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Mar 2018 11:57:06 +0000 (12:57 +0100)
Variable 'val' is initialized with a value that is never read, it is
updated with a new value again after intitialization. Remove the
redundant initialization and move the declaration and assignment into
the scope of the for-loop.

Cleans up clang warning:
drivers/staging/comedi/drivers/adl_pci6208.c:61:15: warning: Value
stored to 'val' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adl_pci6208.c

index d39b4eabce8d17b4f6bd8802ee084f868d673754..e21840e9002d8213c3a82eecd4b25742654824dd 100644 (file)
@@ -58,12 +58,11 @@ static int pci6208_ao_insn_write(struct comedi_device *dev,
                                 unsigned int *data)
 {
        unsigned int chan = CR_CHAN(insn->chanspec);
-       unsigned int val = s->readback[chan];
        int ret;
        int i;
 
        for (i = 0; i < insn->n; i++) {
-               val = data[i];
+               unsigned int val = data[i];
 
                /* D/A transfer rate is 2.2us */
                ret = comedi_timeout(dev, s, insn, pci6208_ao_eoc, 0);