]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
clk: qcom: clk-alpha-pll: fix CAL_L write in alpha_pll_fabia_prepare
authorJonathan Marek <jonathan@marek.ca>
Wed, 9 Jun 2021 02:28:52 +0000 (22:28 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:04 +0000 (09:31 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938340
[ Upstream commit 7f54bf2640e877c8a9b4cc7e2b29f82e3ca1a284 ]

Caught this when looking at alpha-pll code. Untested but it is clear that
this was intended to write to PLL_CAL_L_VAL and not PLL_ALPHA_VAL.

Fixes: 691865bad627 ("clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Link: https://lore.kernel.org/r/20210609022852.4151-1-jonathan@marek.ca
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/clk/qcom/clk-alpha-pll.c

index 21c357c26ec42a8e98d505d48dc62c4eaa569ef2..05851af9c2c61e3fdbe5cd203a3e9adf25b57c11 100644 (file)
@@ -1228,7 +1228,7 @@ static int alpha_pll_fabia_prepare(struct clk_hw *hw)
                return ret;
 
        /* Setup PLL for calibration frequency */
-       regmap_write(pll->clkr.regmap, PLL_ALPHA_VAL(pll), cal_l);
+       regmap_write(pll->clkr.regmap, PLL_CAL_L_VAL(pll), cal_l);
 
        /* Bringup the PLL at calibration frequency */
        ret = clk_alpha_pll_enable(hw);