]> git.proxmox.com Git - mirror_qemu.git/commitdiff
debian-bootstrap.pre: Modern shell scripting (use $() instead of ``)
authorMao Zhongyi <maozhongyi@cmss.chinamobile.com>
Mon, 22 Oct 2018 08:48:23 +0000 (16:48 +0800)
committerThomas Huth <thuth@redhat.com>
Wed, 24 Oct 2018 06:39:03 +0000 (07:39 +0100)
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.

Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/docker/dockerfiles/debian-bootstrap.pre

index 3b0ef953747bbb1d0a85efef1f1aea3fd391ca36..c164778c302127b7044dab0921b11cca815b5cfd 100755 (executable)
@@ -2,7 +2,7 @@
 #
 # Simple wrapper for debootstrap, run in the docker build context
 #
-FAKEROOT=`which fakeroot 2> /dev/null`
+FAKEROOT=$(which fakeroot 2> /dev/null)
 # debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
 MIN_DEBOOTSTRAP_VERSION=1.0.67
 
@@ -52,7 +52,7 @@ fi
 
 if [ -z $DEBOOTSTRAP_DIR ]; then
     NEED_DEBOOTSTRAP=false
-    DEBOOTSTRAP=`which debootstrap 2> /dev/null`
+    DEBOOTSTRAP=$(which debootstrap 2> /dev/null)
     if [ -z $DEBOOTSTRAP ]; then
         echo "No debootstrap installed, attempting to install from SCM"
         NEED_DEBOOTSTRAP=true