RDMA/bnxt_re: Remove a redundant check inside bnxt_re_update_gid

The NULL check inside bnxt_re_update_gid() always return false.  If
sgid_tbl->tbl is not allocated, then dev_init would have failed.

Fixes: 5fac5b1b297f ("RDMA/bnxt_re: Add vlan tag for untagged RoCE traffic when PFC is configured")
Link: https://lore.kernel.org/r/1684478897-12247-5-git-send-email-selvin.xavier@broadcom.com
Reviewed-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
Reviewed-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index a44f2900e343ba163053a62481f5c5112c46166c..4718af6c4c47b0027a9df75f817252e2f7e93667 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -969,12 +969,6 @@ static int bnxt_re_update_gid(struct bnxt_re_dev *rdev)
        if (!ib_device_try_get(&rdev->ibdev))
                return 0;
 
-       if (!sgid_tbl) {
-               ibdev_err(&rdev->ibdev, "QPLIB: SGID table not allocated");
-               rc = -EINVAL;
-               goto out;
-       }
-
        for (index = 0; index < sgid_tbl->active; index++) {
                gid_idx = sgid_tbl->hw_id[index];
 
@@ -992,7 +986,7 @@ static int bnxt_re_update_gid(struct bnxt_re_dev *rdev)
                rc = bnxt_qplib_update_sgid(sgid_tbl, &gid, gid_idx,
                                            rdev->qplib_res.netdev->dev_addr);
        }
-out:
+
        ib_device_put(&rdev->ibdev);
        return rc;
 }