]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: dsa: mv88e6xxx: use dsa_switch_for_each_port in mv88e6xxx_lag_sync_masks
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 23 Feb 2022 14:00:48 +0000 (16:00 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 25 Feb 2022 05:31:43 +0000 (21:31 -0800)
Make the intent of the code more clear by using the dedicated helper for
iterating over the ports of a switch.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/chip.c

index 23151287387c35080f434686931350935f18b39c..8868110fcc9cfff02207697764480e80a457a710 100644 (file)
@@ -6280,8 +6280,8 @@ static int mv88e6xxx_lag_sync_masks(struct dsa_switch *ds)
        ivec = BIT(mv88e6xxx_num_ports(chip)) - 1;
 
        /* Disable all masks for ports that _are_ members of a LAG. */
-       list_for_each_entry(dp, &ds->dst->ports, list) {
-               if (!dp->lag_dev || dp->ds != ds)
+       dsa_switch_for_each_port(dp, ds) {
+               if (!dp->lag_dev)
                        continue;
 
                ivec &= ~BIT(dp->index);