]> git.proxmox.com Git - mirror_ovs.git/commitdiff
netdev-dpdk: Avoid warning for snprintf() call.
authorAaron Conole <aconole@redhat.com>
Fri, 15 Jun 2018 13:20:12 +0000 (09:20 -0400)
committerBen Pfaff <blp@ovn.org>
Fri, 15 Jun 2018 18:26:14 +0000 (11:26 -0700)
lib/netdev-dpdk.c: In function :
lib/netdev-dpdk.c:2865:49: warning:  output may be truncated before the last format character [-Wformat-truncation=]
        snprintf(vhost_vring, 16, "vring_%d_size", i);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Suggested-by: Ben Pfaff <blp@ovn.org>
Signed-off-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Ilya Maximets <i.maximets@samsung.com>
lib/netdev-dpdk.c

index a76e489a2b5d550be2ae73073b76df1f1d3a1442..1bde9cfe707de28bfa30dc93dee2728a204c816c 100644 (file)
@@ -2883,11 +2883,10 @@ netdev_dpdk_vhost_user_get_status(const struct netdev *netdev,
 
     for (int i = 0; i < vring_num; i++) {
         struct rte_vhost_vring vring;
-        char vhost_vring[16];
 
         rte_vhost_get_vhost_vring(vid, i, &vring);
-        snprintf(vhost_vring, 16, "vring_%d_size", i);
-        smap_add_format(args, vhost_vring, "%d", vring.size);
+        smap_add_nocopy(args, xasprintf("vring_%d_size", i),
+                        xasprintf("%d", vring.size));
     }
 
     ovs_mutex_unlock(&dev->mutex);