]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
isdn: eicon: Return on error
authorJiri Slaby <jirislaby@gmail.com>
Wed, 4 Nov 2009 16:30:08 +0000 (08:30 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Nov 2009 16:30:08 +0000 (08:30 -0800)
When diva_strace_read_uint returns an error, return even from
process_idi_event, because l2_state is uninitialized.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Acked-by: Armin Schindler <armin@melware.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/eicon/maintidi.c

index 23960cb6eaab311bd834bd37558930509301c9ce..41c26e7564528c9d88b3eb59b74f260120378701 100644 (file)
@@ -959,8 +959,9 @@ static int process_idi_event (diva_strace_context_t* pLib,
        }
        if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) {
                char* tmp = &pLib->lines[0].pInterface->Layer2[0];
-    dword l2_state;
-    diva_strace_read_uint (pVar, &l2_state);
+               dword l2_state;
+               if (diva_strace_read_uint(pVar, &l2_state))
+                       return -1;
 
                switch (l2_state) {
                        case 0: