]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
GFS2: Only set PageChecked for jdata pages
authorBob Peterson <rpeterso@redhat.com>
Wed, 14 Feb 2018 16:32:39 +0000 (09:32 -0700)
committerBob Peterson <rpeterso@redhat.com>
Thu, 8 Mar 2018 16:26:20 +0000 (09:26 -0700)
Before this patch, GFS2 was setting the PageChecked flag for ordered
write pages. This is unnecessary. The ext3 file system only does it
for jdata, and it's only used in jdata circumstances. It only muddies
the already murky waters of writing pages in the aops.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/aops.c

index 2f725b4a386b38321e0031687fce3db1807ddc2c..f58716567972ec121762db4ce94a4da4245b6a8d 100644 (file)
@@ -940,13 +940,13 @@ failed:
 }
 
 /**
- * gfs2_set_page_dirty - Page dirtying function
+ * jdata_set_page_dirty - Page dirtying function
  * @page: The page to dirty
  *
  * Returns: 1 if it dirtyed the page, or 0 otherwise
  */
  
-static int gfs2_set_page_dirty(struct page *page)
+static int jdata_set_page_dirty(struct page *page)
 {
        SetPageChecked(page);
        return __set_page_dirty_buffers(page);
@@ -1214,7 +1214,7 @@ static const struct address_space_operations gfs2_ordered_aops = {
        .readpages = gfs2_readpages,
        .write_begin = gfs2_write_begin,
        .write_end = gfs2_write_end,
-       .set_page_dirty = gfs2_set_page_dirty,
+       .set_page_dirty = __set_page_dirty_buffers,
        .bmap = gfs2_bmap,
        .invalidatepage = gfs2_invalidatepage,
        .releasepage = gfs2_releasepage,
@@ -1231,7 +1231,7 @@ static const struct address_space_operations gfs2_jdata_aops = {
        .readpages = gfs2_readpages,
        .write_begin = gfs2_write_begin,
        .write_end = gfs2_write_end,
-       .set_page_dirty = gfs2_set_page_dirty,
+       .set_page_dirty = jdata_set_page_dirty,
        .bmap = gfs2_bmap,
        .invalidatepage = gfs2_invalidatepage,
        .releasepage = gfs2_releasepage,