drm/bridge: tfp410: Fix setup and hold time calculation

This fixes a bug in the calculation of the setup and hold times based on
the deskew configuration.

Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200617094633.19663-5-ricardo.canuelo@collabora.com

diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
index dfde811f3411a08ea4465a3839f88d38d427826e..21d99b4ea0c9b576bd0a038d4bcda6020265c456 100644 (file)
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -278,8 +278,8 @@ static int tfp410_parse_timings(struct tfp410 *dvi, bool i2c)
        if (deskew > 7)
                return -EINVAL;
 
-       timings->setup_time_ps = min(0, 1200 - 350 * ((s32)deskew - 4));
-       timings->hold_time_ps = min(0, 1300 + 350 * ((s32)deskew - 4));
+       timings->setup_time_ps = 1200 - 350 * ((s32)deskew - 4);
+       timings->hold_time_ps = max(0, 1300 + 350 * ((s32)deskew - 4));
 
        return 0;
 }