]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
net: ieee802154: forbid monitor for add llsec dev
authorAlexander Aring <aahringo@redhat.com>
Mon, 5 Apr 2021 00:30:46 +0000 (20:30 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 4 May 2021 14:13:31 +0000 (16:13 +0200)
BugLink: https://bugs.launchpad.net/bugs/1926493
[ Upstream commit 5303f956b05a2886ff42890908156afaec0f95ac ]

This patch forbids to add llsec dev for monitor interfaces which we
don't support yet. Otherwise we will access llsec mib which isn't
initialized for monitors.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210405003054.256017-8-aahringo@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/ieee802154/nl802154.c

index 97074180c2e5fee6a377549056d4eecbf789d617..797888b4b2cefbf0df3b5f3eedfaea9d51a1e8e2 100644 (file)
@@ -1784,6 +1784,9 @@ static int nl802154_add_llsec_dev(struct sk_buff *skb, struct genl_info *info)
        struct wpan_dev *wpan_dev = dev->ieee802154_ptr;
        struct ieee802154_llsec_device dev_desc;
 
+       if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR)
+               return -EOPNOTSUPP;
+
        if (ieee802154_llsec_parse_device(info->attrs[NL802154_ATTR_SEC_DEVICE],
                                          &dev_desc) < 0)
                return -EINVAL;