]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
staging: mt7621-gpio: use module_platform_driver() instead subsys initcall
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Fri, 25 May 2018 16:54:48 +0000 (18:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Jun 2018 09:17:05 +0000 (11:17 +0200)
The driver's init function don't do anything besides registering the platform
driver, and the exit function which is not included in the driver should only
do driver unregister. Because of this module_platform_driver() macro could
just be used instead of having separate functions.

Currently the macro is not being used because the driver is initialized at
subsys init call level but this isn't necessary since platform devices are
defined in the DT as dependencies so there's no need for init calls order.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-gpio/gpio-mt7621.c

index 64169367861cc86ea889ec2e318c57d8275cb454..d41cc3ed437c7b2b1b18ac57134024acd736347a 100644 (file)
@@ -379,10 +379,4 @@ static struct platform_driver mediatek_gpio_driver = {
        },
 };
 
-static int __init
-mediatek_gpio_init(void)
-{
-       return platform_driver_register(&mediatek_gpio_driver);
-}
-
-subsys_initcall(mediatek_gpio_init);
+module_platform_driver(mediatek_gpio_driver);