]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
lightnvm: remove set but not used variables 'data_len' and 'rq_len'
authorYueHaibing <yuehaibing@huawei.com>
Wed, 7 Aug 2019 13:18:47 +0000 (21:18 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 Aug 2019 13:34:34 +0000 (07:34 -0600)
drivers/lightnvm/pblk-read.c: In function pblk_submit_read_gc:
drivers/lightnvm/pblk-read.c:423:6: warning: variable data_len set but not used [-Wunused-but-set-variable]
drivers/lightnvm/pblk-recovery.c: In function pblk_recov_scan_oob:
drivers/lightnvm/pblk-recovery.c:368:15: warning: variable rq_len set but not used [-Wunused-but-set-variable]

They are not used since commit 48e5da725581 ("lightnvm:
move metadata mapping to lower level driver")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/pblk-read.c
drivers/lightnvm/pblk-recovery.c

index d572d4559e4ef0aad125c1e2e05227037015f4c8..0cdc48f9cfbfddaeb234479c0311100ca4746e0d 100644 (file)
@@ -420,7 +420,6 @@ int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
        struct nvm_tgt_dev *dev = pblk->dev;
        struct nvm_geo *geo = &dev->geo;
        struct nvm_rq rqd;
-       int data_len;
        int ret = NVM_IO_OK;
 
        memset(&rqd, 0, sizeof(struct nvm_rq));
@@ -445,7 +444,6 @@ int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
        if (!(gc_rq->secs_to_gc))
                goto out;
 
-       data_len = (gc_rq->secs_to_gc) * geo->csecs;
        rqd.opcode = NVM_OP_PREAD;
        rqd.nr_ppas = gc_rq->secs_to_gc;
 
index d5e210c3c5b7b7d8ebd1b159b0303fe89decef6e..299ef47a17b22ae56747b824961c029691e6fc8a 100644 (file)
@@ -365,7 +365,7 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struct pblk_line *line,
        __le64 *lba_list;
        u64 paddr = pblk_line_smeta_start(pblk, line) + lm->smeta_sec;
        bool padded = false;
-       int rq_ppas, rq_len;
+       int rq_ppas;
        int i, j;
        int ret;
        u64 left_ppas = pblk_sec_in_open_line(pblk, line) - lm->smeta_sec;
@@ -388,7 +388,6 @@ next_rq:
        rq_ppas = pblk_calc_secs(pblk, left_ppas, 0, false);
        if (!rq_ppas)
                rq_ppas = pblk->min_write_pgs;
-       rq_len = rq_ppas * geo->csecs;
 
 retry_rq:
        rqd->bio = NULL;