]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
usb: chipidea: fix precedence bug in ci_requests_show()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 30 Mar 2013 10:53:54 +0000 (12:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Mar 2013 15:08:40 +0000 (08:08 -0700)
The intent here was to have parenthesis around the (ci->hw_ep_max / 2)
so that it counts like "0 1 2 0 1 2".  In the current code, the mod
operation happens first so it counts like "0 0 1 1 2 2".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[rebased on top of debug.c changes]
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/debug.c

index 5738079734e388eebc7bb261d9f6a23ae1986e7c..36a7063a6cba04f55e1b25ea062f2896f9524dda 100644 (file)
@@ -175,7 +175,7 @@ static int ci_requests_show(struct seq_file *s, void *data)
                        req = list_entry(ptr, struct ci13xxx_req, queue);
 
                        seq_printf(s, "EP=%02i: TD=%08X %s\n",
-                                  i % ci->hw_ep_max/2, (u32)req->dma,
+                                  i % (ci->hw_ep_max / 2), (u32)req->dma,
                                   ((i < ci->hw_ep_max/2) ? "RX" : "TX"));
 
                        for (j = 0; j < qsize; j++)