]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
drivers/video/arcfb.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 18 Sep 2012 12:08:00 +0000 (14:08 +0200)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Sat, 22 Sep 2012 21:41:53 +0000 (21:41 +0000)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/arcfb.c

index a1d58e9d3073e1ff57bead6eb1cefbe4d98e6f84..4659d5da6ff88d2a59270b9b2db69aec0c14908d 100644 (file)
@@ -552,6 +552,7 @@ static int __devinit arcfb_probe(struct platform_device *dev)
                                "arcfb", info)) {
                        printk(KERN_INFO
                                "arcfb: Failed req IRQ %d\n", par->irq);
+                       retval = -EBUSY;
                        goto err1;
                }
        }