]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
leds: class: The -ENOTSUPP should never be seen by user space
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Mon, 10 May 2021 09:50:18 +0000 (12:50 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:31:18 +0000 (09:31 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938340
[ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ]

Drop the bogus error code and let of_led_get() to take care about absent
of_node.

Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver")
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/leds/led-class.c

index 131ca83f5fb380f05e0efd0042262a92f400623a..4365c1cc4505ffa9b7851e92aa1273c9899de293 100644 (file)
@@ -286,10 +286,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev,
        if (!dev)
                return ERR_PTR(-EINVAL);
 
-       /* Not using device tree? */
-       if (!IS_ENABLED(CONFIG_OF) || !dev->of_node)
-               return ERR_PTR(-ENOTSUPP);
-
        led = of_led_get(dev->of_node, index);
        if (IS_ERR(led))
                return led;