According to the QAPI schema, there is a "-" and not a "_" between
"window" and "close", and we're also talking about "window-close"
in the long parameter description in qemu-options.hx, so we should
make sure that we rather use the variant with the "-" by default
instead of only allowing the one with the "_" here. The old way
still stays enabled for compatibility, but we deprecate it, so that
we can switch to a QAPIfied parameter one day more easily.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <
20210630163231.467987-3-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
if they were not given. The property is therefore useless and should not be
specified.
+``-display sdl,window_close=...`` (since 6.1)
+'''''''''''''''''''''''''''''''''''''''''''''
+
+Use ``-display sdl,window-close=...`` instead (i.e. with a minus instead of
+an underscore between "window" and "close").
+
QEMU Machine Protocol (QMP) commands
------------------------------------
#endif
#if defined(CONFIG_SDL)
"-display sdl[,alt_grab=on|off][,ctrl_grab=on|off]\n"
- " [,window_close=on|off][,gl=on|core|es|off]\n"
+ " [,window-close=on|off][,gl=on|core|es|off]\n"
#endif
#if defined(CONFIG_GTK)
"-display gtk[,grab_on_hover=on|off][,gl=on|off]|\n"
} else {
goto invalid_sdl_args;
}
- } else if (strstart(opts, ",window_close=", &nextopt)) {
+ } else if (strstart(opts, ",window_close=", &nextopt) ||
+ strstart(opts, ",window-close=", &nextopt)) {
+ if (strstart(opts, ",window_close=", NULL)) {
+ warn_report("window_close with an underscore is deprecated,"
+ " please use window-close instead.");
+ }
opts = nextopt;
dpy.has_window_close = true;
if (strstart(opts, "on", &nextopt)) {