]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
tipc: remove joining group member from congested list
authorJon Maloy <jon.maloy@ericsson.com>
Wed, 20 Dec 2017 10:03:15 +0000 (11:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Dec 2017 19:56:48 +0000 (14:56 -0500)
When we receive a JOIN message from a peer member, the message may
contain an advertised window value ADV_IDLE that permits removing the
member in question from the tipc_group::congested list. However, since
the removal has been made conditional on that the advertised window is
*not* ADV_IDLE, we miss this case. This has the effect that a sender
sometimes may enter a state of permanent, false, broadcast congestion.

We fix this by unconditinally removing the member from the congested
list before calling tipc_member_update(), which might potentially sort
it into the list again.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/group.c

index bbc004eaa31a382a6a7e9d6ede4ac6270ae5c7de..7ebbdeb2a90e1d8429113b81370ad67f05ee633e 100644 (file)
@@ -689,10 +689,8 @@ void tipc_group_proto_rcv(struct tipc_group *grp, bool *usr_wakeup,
                        msg_set_grp_bc_seqno(ehdr, m->bc_syncpt);
                        __skb_queue_tail(inputq, m->event_msg);
                }
-               if (m->window < ADV_IDLE)
-                       tipc_group_update_member(m, 0);
-               else
-                       list_del_init(&m->congested);
+               list_del_init(&m->congested);
+               tipc_group_update_member(m, 0);
                return;
        case GRP_LEAVE_MSG:
                if (!m)