migration: do not allow live-migration with clipboard=vnc

It is not yet supported for QEMU's vdagent device which is used for
the VNC clipboard.

The migration precondition API call will now treat the VNC clipboard
as a local resource. Thus the GUI blocks migration and shows:
"Can't migrate VM with local resources: clipboard=vnc"

QemuMigrate's prepare function will also abort live migration early
when using the VNC clipboard.

Signed-off-by: Markus Frank <m.frank@proxmox.com>
[FE: adapt commit message a bit]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index f5bff533f50b905b178b81f9ce96289fcf447df6..f26adf51d25b5a56907df7b9355f8826cb3508d4 100644 (file)
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -4376,6 +4376,11 @@ __PACKAGE__->register_method({
            PVE::QemuServer::check_local_resources($vmconf, 1);
        delete $missing_mappings_by_node->{$localnode};
 
+       my $vga = PVE::QemuServer::parse_vga($vmconf->{vga});
+       if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') {
+           push $local_resources->@*, "clipboard=vnc";
+       }
+
        # if vm is not running, return target nodes where local storage/mapped devices are available
        # for offline migration
        if (!$res->{running}) {

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index f30ce9f42eb78d3dfc53558219005ab3a4683c2c..b87e47aa9cd4c107f23fe8c42e186f501a83e7c3 100644 (file)
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -255,6 +255,11 @@ sub prepare {
        }
     }
 
+    my $vga = PVE::QemuServer::parse_vga($conf->{vga});
+    if ($running && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') {
+       die "VMs with 'clipboard' set to 'vnc' are not live migratable!\n";
+    }
+
     my $vollist = PVE::QemuServer::get_vm_volumes($conf);
 
     my $storages = {};