]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
at86rf230: remove check if AVDD settled
authorAlexander Aring <alex.aring@gmail.com>
Mon, 14 Apr 2014 16:48:01 +0000 (18:48 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Apr 2014 04:08:22 +0000 (00:08 -0400)
The AVDD regulator is only enabled when the RF section is active TX_ON
(PLL_ON) state. Since commit 7dcbd22a97eb0689e6c583ad630ae0e7341e34c1
("ieee802154: ensure that first RF212 state comes from TRX_OFF").
We are in TRX_OFF state at the time at86rf230_hw_init is run.

Note that this test would only fail in case of a severe hardware
malfunction (faulty/shorted power supply, etc.) so it wasn't all that
useful in the first place.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Reviewed-by: Werner Almesberger <werner@almesberger.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ieee802154/at86rf230.c

index 430bb0db9bc4c7e376ab042d8544d0dc3573cc28..e102eef0b332b3d7d9548dce6b9e94aa3d882e0d 100644 (file)
@@ -1025,14 +1025,6 @@ static int at86rf230_hw_init(struct at86rf230_local *lp)
                return -EINVAL;
        }
 
-       rc = at86rf230_read_subreg(lp, SR_AVDD_OK, &status);
-       if (rc)
-               return rc;
-       if (!status) {
-               dev_err(&lp->spi->dev, "AVDD error\n");
-               return -EINVAL;
-       }
-
        return 0;
 }