]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
mmc: mediatek: fix mem leak in msdc_drv_probe
authorZheng Liang <zhengliang6@huawei.com>
Thu, 12 Nov 2020 09:25:30 +0000 (17:25 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 17 Nov 2020 11:30:30 +0000 (12:30 +0100)
It should use mmc_free_host to free mem in error patch of
msdc_drv_probe.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Liang <zhengliang6@huawei.com>
Reviewed-by: Chaotian Jing <chaotian.jing@mediatek.com>
Link: https://lore.kernel.org/r/20201112092530.32446-1-zhengliang6@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c

index fc5ee5df91adf8af6346a24b2c242af8e6f3e495..eac7838e2dac34c57923ff49d02b1d2b34767742 100644 (file)
@@ -2504,8 +2504,10 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
        host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
                                                                "hrst");
-       if (IS_ERR(host->reset))
-               return PTR_ERR(host->reset);
+       if (IS_ERR(host->reset)) {
+               ret = PTR_ERR(host->reset);
+               goto host_free;
+       }
 
        host->irq = platform_get_irq(pdev, 0);
        if (host->irq < 0) {