]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
can: peak_usb: fix checkpatch warnings
authorMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 5 Apr 2021 10:34:56 +0000 (12:34 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 13 Apr 2021 08:15:43 +0000 (10:15 +0200)
This patch cleans several checkpatch warnings in the peak_usb driver.

Link: https://lore.kernel.org/r/20210406111622.1874957-2-mkl@pengutronix.de
Acked-by: Stephane Grosjean <s.grosjean@peak-system.com>
Tested-by: Stephane Grosjean <s.grosjean@peak-system.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/peak_usb/pcan_usb.c
drivers/net/can/usb/peak_usb/pcan_usb_core.c
drivers/net/can/usb/peak_usb/pcan_usb_core.h
drivers/net/can/usb/peak_usb/pcan_usb_pro.c

index ba509aed7b4c39a3ef167127ecfd8092402add13..e23049c811595932802a67d627c51aafb4f19070 100644 (file)
@@ -401,7 +401,7 @@ static int pcan_usb_update_ts(struct pcan_usb_msg_context *mc)
 {
        __le16 tmp16;
 
-       if ((mc->ptr+2) > mc->end)
+       if ((mc->ptr + 2) > mc->end)
                return -EINVAL;
 
        memcpy(&tmp16, mc->ptr, 2);
@@ -1039,7 +1039,7 @@ const struct peak_usb_adapter pcan_usb = {
                              CAN_CTRLMODE_BERR_REPORTING |
                              CAN_CTRLMODE_CC_LEN8_DLC,
        .clock = {
-               .freq = PCAN_USB_CRYSTAL_HZ / 2 ,
+               .freq = PCAN_USB_CRYSTAL_HZ / 2,
        },
        .bittiming_const = &pcan_usb_const,
 
index e69b005be068a3eb7817c4454fdd78d1e91c19c2..7dff77a6ef70e2611342d0d25886ac769f456be9 100644 (file)
@@ -624,6 +624,7 @@ static int peak_usb_ndo_stop(struct net_device *netdev)
        /* can set bus off now */
        if (dev->adapter->dev_set_bus) {
                int err = dev->adapter->dev_set_bus(dev, 0);
+
                if (err)
                        return err;
        }
index e15b4c78f30957fcbc1e7d0c2491e3e36b47572f..59afe880a48105464d0071be71027b00b3bfb052 100644 (file)
@@ -31,7 +31,7 @@
 /* usb adapters maximum channels per usb interface */
 #define PCAN_USB_MAX_CHANNEL           2
 
-/* maximum length of the usb commands sent to/received from  the devices */
+/* maximum length of the usb commands sent to/received from the devices */
 #define PCAN_USB_MAX_CMD_LEN           32
 
 struct peak_usb_device;
index 2d1b645af76cc59a1fca9ddb05450dfff8698343..ecb08359f7191840564d070bb00abeeb6fd845cb 100644 (file)
@@ -290,7 +290,7 @@ static int pcan_usb_pro_wait_rsp(struct peak_usb_device *dev,
                                           pr->data_type);
 
                        /* check if channel in response corresponds too */
-                       else if ((req_channel != 0xff) && \
+                       else if ((req_channel != 0xff) &&
                                (pr->bus_act.channel != req_channel))
                                netdev_err(dev->netdev,
                                        "got rsp %xh but on chan%u: ignored\n",