]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/i915/psr: Warn for erroneous enabling of both PSR1 and PSR2.
authorDhinakaran Pandiyan <dhinakaran.pandiyan@gmail.com>
Tue, 26 Jun 2018 09:05:22 +0000 (02:05 -0700)
committerDhinakaran Pandiyan <dhinakaran.pandiyan@gmail.com>
Tue, 26 Jun 2018 18:45:07 +0000 (11:45 -0700)
Depending whether PSR1 or PSR2 was configured, we print a warning if the
corresponding control mmio indicated PSR was erroneously enabled. As
Chris pointed out, it makes more sense to check for both the mmio's
since we expect neither PSR1 nor PSR2 to be enabled when psr_activate() is
called.

v2: Read PSR2 control register only on supported platforms (Rodrigo)

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180626090522.17682-1-dhinakaran.pandiyan@intel.com
drivers/gpu/drm/i915/intel_psr.c

index 276070d597e14674876f203184d02d5bb8140529..1b439629cb6604c5a2fbba51da8fd6da1abcbae1 100644 (file)
@@ -521,10 +521,9 @@ static void intel_psr_activate(struct intel_dp *intel_dp)
        struct drm_device *dev = intel_dig_port->base.base.dev;
        struct drm_i915_private *dev_priv = to_i915(dev);
 
-       if (dev_priv->psr.psr2_enabled)
+       if (INTEL_GEN(dev_priv) >= 9)
                WARN_ON(I915_READ(EDP_PSR2_CTL) & EDP_PSR2_ENABLE);
-       else
-               WARN_ON(I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE);
+       WARN_ON(I915_READ(EDP_PSR_CTL) & EDP_PSR_ENABLE);
        WARN_ON(dev_priv->psr.active);
        lockdep_assert_held(&dev_priv->psr.lock);