]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: netsec: Fix signedness bug in netsec_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 25 Sep 2019 10:56:38 +0000 (13:56 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Sep 2019 08:03:07 +0000 (10:03 +0200)
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as an unsigned int so the error handling is never
triggered.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/socionext/netsec.c

index 1502fe8b0456c17a8e4b04831189d9f9175d206f..55db7fbd43cc3cfd112c31803e1318bda1555e05 100644 (file)
@@ -2007,7 +2007,7 @@ static int netsec_probe(struct platform_device *pdev)
                           NETIF_MSG_LINK | NETIF_MSG_PROBE;
 
        priv->phy_interface = device_get_phy_mode(&pdev->dev);
-       if (priv->phy_interface < 0) {
+       if ((int)priv->phy_interface < 0) {
                dev_err(&pdev->dev, "missing required property 'phy-mode'\n");
                ret = -ENODEV;
                goto free_ndev;