NFSD: prevent underflow in nfssvc_decode_writeargs()

BugLink: https://bugs.launchpad.net/bugs/1969110
commit 184416d4b98509fb4c3d8fc3d6dc1437896cc159 upstream.

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 614a61e1592051cc42d3c38f899c9f7bdaad8a1d)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>

diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
index 312fd289be583d045e90a286ce0e0485a87874bb..9700ad433b49860320bcfce497fbd48ace16f061 100644 (file)
--- a/fs/nfsd/nfsproc.c
+++ b/fs/nfsd/nfsproc.c
@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
        unsigned long cnt = argp->len;
        unsigned int nvecs;
 
-       dprintk("nfsd: WRITE    %s %d bytes at %d\n",
+       dprintk("nfsd: WRITE    %s %u bytes at %d\n",
                SVCFH_fmt(&argp->fh),
                argp->len, argp->offset);
 

diff --git a/fs/nfsd/xdr.h b/fs/nfsd/xdr.h
index 80fd6d7f3404a6fde68860c23ecadadde34e772e..863a35f24910a4b49c409f9362f5791a4aeadf95 100644 (file)
--- a/fs/nfsd/xdr.h
+++ b/fs/nfsd/xdr.h
@@ -32,7 +32,7 @@ struct nfsd_readargs {
 struct nfsd_writeargs {
        svc_fh                  fh;
        __u32                   offset;
-       int                     len;
+       __u32                   len;
        struct xdr_buf          payload;
 };