]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
libertas: precedence bug
authorDan Carpenter <error27@gmail.com>
Thu, 22 Jul 2010 12:21:02 +0000 (14:21 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 26 Jul 2010 19:32:42 +0000 (15:32 -0400)
Negate has precedence over comparison so the original test was always
false.  (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/tx.c

index 411a3bbf035eaa716393603808b8f2cb7948ac45..8000ca6165d0b4e619f6fafb5a5ef1f9e7a73367 100644 (file)
@@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
 {
        struct tx_radiotap_hdr *radiotap_hdr;
 
-       if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
+       if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
            priv->currenttxskb == NULL)
                return;