]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net/ulp: Remove redundant ->clone() test in inet_clone_ulp().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Fri, 17 Feb 2023 20:09:20 +0000 (12:09 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 21 Feb 2023 00:31:49 +0000 (16:31 -0800)
Commit 2c02d41d71f9 ("net/ulp: prevent ULP without clone op from entering
the LISTEN status") guarantees that all ULP listeners have clone() op, so
we no longer need to test it in inet_clone_ulp().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230217200920.85306-1-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/inet_connection_sock.c

index eedcf4146d29e72d5d184537a97bd124637bb314..65ad4251f6fd849c7aeb0d981dc337111fb246b0 100644 (file)
@@ -1122,8 +1122,7 @@ static void inet_clone_ulp(const struct request_sock *req, struct sock *newsk,
        if (!icsk->icsk_ulp_ops)
                return;
 
-       if (icsk->icsk_ulp_ops->clone)
-               icsk->icsk_ulp_ops->clone(req, newsk, priority);
+       icsk->icsk_ulp_ops->clone(req, newsk, priority);
 }
 
 /**