coverity: fix leak when ipv6 gw is auto

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

diff --git a/src/lxc/confile.c b/src/lxc/confile.c
index d0a404f4a713b9de62dc3da491beefc0fe096b0d..fbae861bf57d0df94aa2b6e998186a163c0a355c 100644 (file)
--- a/src/lxc/confile.c
+++ b/src/lxc/confile.c
@@ -782,12 +782,6 @@ static int config_network_ipv6_gateway(const char *key, const char *value,
        if (!netdev)
                return -1;
 
-       gw = malloc(sizeof(*gw));
-       if (!gw) {
-               SYSERROR("failed to allocate ipv6 gateway address");
-               return -1;
-       }
-
        if (!value) {
                ERROR("no ipv6 gateway address specified");
                return -1;
@@ -797,6 +791,12 @@ static int config_network_ipv6_gateway(const char *key, const char *value,
                netdev->ipv6_gateway = NULL;
                netdev->ipv6_gateway_auto = true;
        } else {
+               gw = malloc(sizeof(*gw));
+               if (!gw) {
+                       SYSERROR("failed to allocate ipv6 gateway address");
+                       return -1;
+               }
+
                if (!inet_pton(AF_INET6, value, gw)) {
                        SYSERROR("invalid ipv6 gateway address: %s", value);
                        free(gw);