]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Tue, 26 May 2020 06:22:49 +0000 (08:22 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 28 May 2020 09:38:57 +0000 (11:38 +0200)
To avoid the orphan I/O memory region being added in the /unattached
QOM container, register the PCI device as its owner.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200526062252.19852-12-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/display/vmware_vga.c

index 5c0fc49d9d6eff2636b6978d469007112dabf4c5..2579f6b218dcff32dec1254f18150d61db02ef44 100644 (file)
@@ -1306,7 +1306,7 @@ static void pci_vmsvga_realize(PCIDevice *dev, Error **errp)
     dev->config[PCI_LATENCY_TIMER] = 0x40;
     dev->config[PCI_INTERRUPT_LINE] = 0xff;          /* End */
 
-    memory_region_init_io(&s->io_bar, NULL, &vmsvga_io_ops, &s->chip,
+    memory_region_init_io(&s->io_bar, OBJECT(dev), &vmsvga_io_ops, &s->chip,
                           "vmsvga-io", 0x10);
     memory_region_set_flush_coalesced(&s->io_bar);
     pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io_bar);