]> git.proxmox.com Git - pve-kernel-meta.git/commitdiff
boot-tool: shellcheck lint fixes
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 22 Feb 2022 16:28:34 +0000 (17:28 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 22 Feb 2022 16:28:34 +0000 (17:28 +0100)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
bin/proxmox-boot-tool

index 178b6fb33110c7d80af594f0938fdbd948d7ece6..766eaada469d5a073267d8b7b76e6da11b759e31 100755 (executable)
@@ -98,7 +98,7 @@ format() {
 
        part_basename=$(basename "$bdev")
        if [ -z "$part_basename" ]; then
-               if [ $part != $bdev ]; then
+               if [ "$part" != "$bdev" ]; then
                    symlinkmsg=" -> '$bdev'"
                fi
                warn "E: unable to determine basename of '$part'$symlinkmsg"
@@ -162,7 +162,7 @@ init() {
        else
                echo "Installing grub i386-pc target.."
                grub-install.real \
-                       --boot-directory $esp_mp \
+                       --boot-directory "$esp_mp" \
                        --target i386-pc \
                        --no-floppy \
                        --bootloader-id='proxmox' \
@@ -183,7 +183,7 @@ _clean_impl() {
                warn 'E: /dev/disk/by-uuid does not exist, aborting!'
                exit 1
        fi
-       echo -n "Checking whether ESP '$curr_uuid' exists.. "
+       printf "Checking whether ESP '%s' exists.. " "$curr_uuid" # avoid newline
        if [ -e "/dev/disk/by-uuid/$curr_uuid" ]; then
                echo "Found!"
        else