]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
modpost: restore the warning message for missing symbol versions
authorMasahiro Yamada <masahiroy@kernel.org>
Fri, 1 Apr 2022 15:56:10 +0000 (00:56 +0900)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:40:13 +0000 (14:40 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
commit bf5c0c2231bcab677e5cdfb7f73e6c79f6d8c2d4 upstream.

This log message was accidentally chopped off.

I was wondering why this happened, but checking the ML log, Mark
precisely followed my suggestion [1].

I just used "..." because I was too lazy to type the sentence fully.
Sorry for the confusion.

[1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/

Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 9f20ce95db3d57fa0cb8e6179bf570ca6af2d998)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
scripts/mod/modpost.c

index cb8ab7d91d30722b2653537abe5a41d7cdc69030..ca491aa2b376283f0778234914603d4f73f79f1f 100644 (file)
@@ -669,7 +669,7 @@ static void handle_modversion(const struct module *mod,
        unsigned int crc;
 
        if (sym->st_shndx == SHN_UNDEF) {
-               warn("EXPORT symbol \"%s\" [%s%s] version ...\n"
+               warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
                     "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
                     symname, mod->name, mod->is_vmlinux ? "" : ".ko",
                     symname);