]> git.proxmox.com Git - pve-container.git/commitdiff
pct: avoid variable declared in conditional statement
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 11 Apr 2023 14:41:21 +0000 (16:41 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 11 Apr 2023 14:41:21 +0000 (16:41 +0200)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
src/PVE/CLI/pct.pm

index d559d00f33b75f0918d02a8621fd2e0b076aef1c..ff75d33d89628f83fd5367d8b7ccc70c23c6d0b5 100755 (executable)
@@ -460,11 +460,12 @@ sub create_file {
 
     if (defined($uid) || defined($gid)) {
        $trunc = 1;
-       my ($fuid, $fgid) = (stat($fd))[4,5] if !defined($uid) || !defined($gid);
-       $uid = $fuid if !defined($uid);
-       $gid = $fgid if !defined($gid);
-       chown($uid, $gid, $fd)
-           or die "failed to change file owner: $!\n";
+       if (!defined($uid) || !defined($gid)) {
+           my ($fuid, $fgid) = (stat($fd))[4,5];
+           $uid //= $fuid;
+           $gid //= $fgid;
+       }
+       chown($uid, $gid, $fd) or die "failed to change file owner: $!\n";
     }
     return $fd;
 }