]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
firewire: core: add memo about the caller of show functions for device attributes
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 18 Mar 2024 08:59:14 +0000 (17:59 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 21 Mar 2024 12:20:18 +0000 (21:20 +0900)
In the case of firewire core function, the caller of show functions for
device attributes is not only sysfs user, but also device initialization.

This commit adds memo about it against the typical assumption that the
functions are just dedicated to sysfs user.

Link: https://lore.kernel.org/lkml/20240318091759.678326-1-o-takashi@sakamocchi.jp/
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/core-device.c

index f208a02d0ebf717a9bed73072f68c0cf78ebdb68..e6cdb905eeaca70aec09132606d66996d5b87579 100644 (file)
@@ -322,6 +322,7 @@ static ssize_t show_immediate(struct device *dev,
        if (value < 0)
                return -ENOENT;
 
+       // Note that this function is also called by init_fw_attribute_group() with NULL pointer.
        return buf ? sysfs_emit(buf, "0x%06x\n", value) : 0;
 }
 
@@ -357,6 +358,7 @@ static ssize_t show_text_leaf(struct device *dev,
                }
        }
 
+       // Note that this function is also called by init_fw_attribute_group() with NULL pointer.
        if (buf) {
                bufsize = PAGE_SIZE - 1;
        } else {