]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
ath6kl: replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 08:43:18 +0000 (16:43 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 31 Jul 2018 07:48:45 +0000 (10:48 +0300)
ath6kl_bmi_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath6kl/bmi.c

index 334dbd834b3a6b37447ff324ed43f4a389d603f9..bde5a10d470c8e74e169e3f4479d9f2487542c34 100644 (file)
@@ -534,7 +534,7 @@ int ath6kl_bmi_init(struct ath6kl *ar)
        /* cmd + addr + len + data_size */
        ar->bmi.max_cmd_size = ar->bmi.max_data_size + (sizeof(u32) * 3);
 
-       ar->bmi.cmd_buf = kzalloc(ar->bmi.max_cmd_size, GFP_ATOMIC);
+       ar->bmi.cmd_buf = kzalloc(ar->bmi.max_cmd_size, GFP_KERNEL);
        if (!ar->bmi.cmd_buf)
                return -ENOMEM;