]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
gpio: amd-fch: Drop const from resource
authorLinus Walleij <linus.walleij@linaro.org>
Mon, 25 Feb 2019 12:49:34 +0000 (13:49 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 25 Feb 2019 14:04:07 +0000 (15:04 +0100)
The build servers and linux-next are complaining like this:

drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
drivers/gpio/gpio-amd-fch.c:164:49: warning: passing argument 2 of
'devm_ioremap_resource' discards 'const' qualifier from pointer
target type [-Wdiscarded-qualifiers]
priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
                                               ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/platform_device.h:14, from
drivers/gpio/gpio-amd-fch.c:15:
include/linux/device.h:709:15: note: expected 'struct resource *'
but argument is of type 'const struct resource *'
 void __iomem *devm_ioremap_resource(struct device *dev,struct resource *res);
               ^~~~~~~~~~~~~~~~~~~~~

Let's just remove "const" for now.

It is possible that devm_ioremap_resource() should rather
be constified so we can pass const resources as arguments.
But right now I just want to get rid of this build warning.

Fixes: e09d168f13f0 ("gpio: AMD G-Series PCH gpio driver")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Anders Roxell <anders.roxell@linaro.org>
Cc: Enrico Weigelt <info@metux.net>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-amd-fch.c

index 3b4fdce325c15b811a1931864b1977ee9d4f4211..4fd66444ea337449fe821f94b3ef18e7bea93f04 100644 (file)
@@ -25,7 +25,7 @@
 #define AMD_FCH_GPIO_FLAG_WRITE                BIT(22)
 #define AMD_FCH_GPIO_FLAG_READ         BIT(16)
 
-static const struct resource amd_fch_gpio_iores =
+static struct resource amd_fch_gpio_iores =
        DEFINE_RES_MEM_NAMED(
                AMD_FCH_MMIO_BASE + AMD_FCH_GPIO_BANK0_BASE,
                AMD_FCH_GPIO_SIZE,