fix segfault in ping_test src_port handling

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>

diff --git a/tests/ping_test.c b/tests/ping_test.c
index 9dcfcc80c10302b8dee662ea4baa38cc453e01bd..fc6e2cb1d963d7ae986a6dcd45ebafd522475899 100644 (file)
--- a/tests/ping_test.c
+++ b/tests/ping_test.c
@@ -45,16 +45,21 @@ static int tok_inaddrport(char *str, struct sockaddr_in *addr)
        if (!src_host)
                src_host = strdup(strhost);
        strport = strtok_r(NULL, ":", &tmp);
-       if (!src_port)
-               src_port = strdup(strport);
 
        addr->sin_family = AF_INET;
 
-       if (strport == NULL)
+       if (strport == NULL) {
+               src_port = malloc(KNET_MAX_PORT_LEN);
+               if (!src_port) {
+                       printf("no mem?\n");
+                       exit(1);
+               }
+               snprintf(src_port, KNET_MAX_PORT_LEN, "%d", KNET_RING_DEFPORT);
                addr->sin_port = htons(KNET_RING_DEFPORT);
-       else
+       } else {
+               src_port = strdup(strport);
                addr->sin_port = htons(tok_inport(strport));
-
+       }
        return inet_aton(strhost, &addr->sin_addr);
 }